-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make syntax more consistent with expected function behaviour #112
Comments
daxkellie
added a commit
that referenced
this issue
Dec 15, 2021
daxkellie
added a commit
that referenced
this issue
Dec 15, 2021
daxkellie
added a commit
that referenced
this issue
Dec 15, 2021
daxkellie
added a commit
that referenced
this issue
Dec 16, 2021
daxkellie
added a commit
that referenced
this issue
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the current version of galah, functions that manipulated or built queries were identified with a
select_
prefix (i.e.,select_taxa
,select_filters
,select_locations
). With the changes to make syntax more consistent with dplyrfilter
,select
andgroup_by
(#101 ), this makes the syntax ofselect_taxa
an outlier because it does not select columns (which is now whatgalah_select
does).After discussion, we decided that
select_taxa
is really a search function and should be renamedsearch_taxa
, consistent with the existingsearch_fields
function. Expected output ofsearch_
functions will be made consistent as well.Discussion also identified that the difference between
search_
functions andfind_
functions is ambiguous to the user, but mostfind_
functions return a data.frame of possible values. However, not allfind_
functions accept a blank argument (e.g.,find_field_values
andfind_profile_attributes
). To remedy this inconsistent syntax to match their expected behaviour, functions that accept a blank argument and return a data.frame of possible values will be prefixed byshow_all_
:The text was updated successfully, but these errors were encountered: