Skip to content

Commit

Permalink
bug fixes requested by CRAN
Browse files Browse the repository at this point in the history
  • Loading branch information
mjwestgate committed Oct 14, 2023
1 parent c0d8d26 commit 4d093de
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 7 deletions.
6 changes: 5 additions & 1 deletion .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,8 @@
^.github$
^\.github$
^data-raw/
^data-raw$
^data-raw$
^cheatsheet
.RData
.Rapp.history
.Rhistory
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: galah
Type: Package
Title: Download Biodiversity Data from the GBIF Node Network
Version: 1.5.3
Version: 1.5.4
Authors@R:
c(person(given = "Martin",
family = "Westgate",
Expand Down
9 changes: 8 additions & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# galah 1.5.2
# galah 1.5.4
Fix minor bug affecting `devel` version of R on some systems.


# galah 1.5.3
Fix to bugs in help file examples.


# galah 1.5.2
Minor release to resolve issues on CRAN, and a few recent bugs.

### Bug fixes
Expand Down
2 changes: 1 addition & 1 deletion R/utilities_internal.R
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ is_object_check <- function(dots){
# get list of options from ?typeof & ?mode
available_types <- c("logical", "numeric",
"complex", "character", "raw", "list", "NULL", "function",
"name", "call", "any", "bbox")
"name", "any")
# attempt to check multiple types
unlist(lapply(dots, function(a){
modes_df <- data.frame(
Expand Down
6 changes: 3 additions & 3 deletions tests/testthat/test-show_values.R
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ test_that("show_values checks values", {

test_that("show_values accepts search & show_all inputs from fields", {
skip_on_cran()
search <- search_all(lists, "EPBCact1")
search <- search_all(lists, "dr656")
filtered_show <- show_all(lists) |>
dplyr::filter(dataResourceUid == "dr656")
values_search <- search |> show_values()
Expand Down Expand Up @@ -149,7 +149,7 @@ test_that("show_values and search_values work for collections", {
})
expect_equal(nrow(result), 1)
result <- expect_message({
search_collections("co43") |>
search_collections("co214") |>
show_values()
})
expect_equal(nrow(result), 1)
Expand All @@ -168,7 +168,7 @@ test_that("show_values and search_values work for datasets", {
})
expect_equal(nrow(result), 1)
result <- expect_message({
search_datasets("dr14507") |>
search_datasets("dr16247") |>
show_values()
})
expect_equal(nrow(result), 1)
Expand Down

0 comments on commit 4d093de

Please sign in to comment.