Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _getindex and remove some ternary operators #144

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

hyrodium
Copy link
Member

@hyrodium hyrodium commented Jul 6, 2024

This PR fixes #120.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.30%. Comparing base (dae50b1) to head (e8004e6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   94.28%   94.30%   +0.01%     
==========================================
  Files          10       10              
  Lines         683      685       +2     
==========================================
+ Hits          644      646       +2     
  Misses         39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MasanoriKanamaru MasanoriKanamaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!

@hyrodium hyrodium merged commit a42fc1c into main Jul 6, 2024
12 of 13 checks passed
@hyrodium hyrodium deleted the feature/remove_ternary branch September 7, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid ternary operator like (A_B isa Real ? A_B : A_B[i])
2 participants