Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added couple of FAB behaviours #4

Closed

Conversation

igor-brishkoski
Copy link

@Ashok-Varma I don't know if this functionality belongs in the library, I'll leave the descision to you.
If you want to include them it, I'll cleanup the classes and make an entry to the README

2016_04_14_21_56_26_22_04_22_22_04_33
2016_04_14_21_58_16_22_01_21_22_02_35

@jt-gilkeson
Copy link
Contributor

jt-gilkeson commented May 6, 2016

@igor-brishkoski The ScrollFABBehavior doesn't seem to scroll the FAB off the screen (just moves it to the bottom). If you look at the Google Plus app, they scroll the FAB all the way off the screen. May want to do another behavior for this, or fix ScrollFABBehavior if that is what is intended (the commments seem to indicate this, but it looks like mDefaultOffset is always 0?). Or maybe I'm missing some attributes on the FAB?

@Ashok-Varma
Copy link
Owner

Ashok-Varma commented May 6, 2016

yes but we need to modify the way they work. User should be doing all those things instead our bottom bar automatically do that. User could set the FAB style our bottom-bar, bottom-bar will manage that.

We can have a discussion about it. i am modifying a one of this commit i will see what i can do about it. To night i will do the changes. After that you can check the way it behaves, and we can add functionalities else many conflicts gonna occur. Give me 24 hours of time to merge the commits and change the codes a bit and push the change back.

Thankyou verymuch for the support

Ashok-Varma pushed a commit that referenced this pull request May 7, 2016
@Ashok-Varma Ashok-Varma removed this from the 1.2.0 milestone May 14, 2016
@jt-gilkeson
Copy link
Contributor

jt-gilkeson commented Jun 22, 2016

Something that I've seen is that VisibilityFABBehavior doesn't handle flings - the bottom bar correctly hides and shows but the fab only works if you scroll with your finger on the screen, flinging doesn't cause FAB to show or hide.

@Ashok-Varma Ashok-Varma closed this Jul 2, 2016
@Ashok-Varma Ashok-Varma added this to the 1.3.0 milestone Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants