Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added HDMR{InclusionRepetition} as default instead of HDMR{Hurdle} #9

Merged
merged 37 commits into from
Jun 28, 2019
Merged

Added HDMR{InclusionRepetition} as default instead of HDMR{Hurdle} #9

merged 37 commits into from
Jun 28, 2019

Conversation

AsafManela
Copy link
Owner

  • Theoretically motivated shifters
  • Performance improvements (typesafety, standardize only once)
  • Improved docs and python tutorial

AsafManela added 30 commits April 24, 2019 17:05
@AsafManela
[WIP] switching to typesafe versions of Lasso segmenet selectors
7ca990d
@AsafManela
removed most select kwargs in favor of args. tests pass with type saf…
1715a6a 
…e coefs
@AsafManela
removed coef(::DMRCoefs; select) option
92e3451
@AsafManela
[WIP] switching to typesafe versions of Lasso segmenet selectors
5ee0d8f
@AsafManela
removed most select kwargs in favor of args. tests pass with type saf…
1e663aa 
…e coefs
@AsafManela
removed coef(::DMRCoefs; select) option
bd8327f
@AsafManela
Merge branch 'typesafe_segselect' of https://github.com/AsafManela/Hu…
9b1c41f 
…rdleDMR.jl into typesafe_segselect
@AsafManela
more time for benchmarking trials
0042a1e
@AsafManela
added benchmarks judging script
85b2c7a
@AsafManela
improved type stability of coef-related methods and types
722662b
@AsafManela
added CVSegSelect supertype for MinCVKfold
e64fe9a
@AsafManela
made Hurdle struct parametric
f3680f2
@AsafManela
added InclusionRepetition <: TwoPartModel
560a526
@AsafManela
cleaned up test files
ff35b5a
@AsafManela
corrected fitpos for inrep
877c46f
@AsafManela
generalized hdmr to take inrep too, but still problems with HDMRPaths…
639c22d 
… methods
@AsafManela
fixed coversion at end of dmrpaths and hdmrpaths
1776179
@AsafManela
fit(HDMRCoefs seems to work but no fit(HDMRPaths
6eefe2b
@AsafManela
fit(HDMRPaths...) now works
332aea2
@AsafManela
tests pass except when all paths are missing
aed095b
@AsafManela
all tests pass
e7b81bc
@AsafManela
standardizing covars only once per dmr / hdmr call. Closes #3
bdbde9a
@AsafManela
- no longer propagating showwarnings to fit(TwoPartModel,...) calls i…
cc7aa41 
…n hdmr

- cleaned up tests
@AsafManela
optionally suppress warnings in fitpos and fitzero, especially to avo…
c327a0b 
…id LambertW's warnings
@AsafManela
added includel kwarg to srproj and made it true be default only in th…
35d5215 
…e InclusionRepetition model
@AsafManela
using GLM.Link made explicit
d47773b
@AsafManela
using GLM private methods made explicit in tests
d1b3e4c
@AsafManela
Switched to Project.toml
b953051
@AsafManela
Refactored and cleaned up hdmr tests
8146e64
@AsafManela
changed HDMR default model to InclusionRepetition
94a0403
@AsafManela AsafManela changed the title Added HDMR{InclusionRepetition} in as default instead of HDMR{Hurdle} Added HDMR{InclusionRepetition} as default instead of HDMR{Hurdle} Jun 28, 2019
@AsafManela AsafManela merged commit f5fb7ae into master Jun 28, 2019
@AsafManela AsafManela deleted the dsmr branch June 28, 2019 13:14
@AsafManela AsafManela restored the dsmr branch May 8, 2020 20:11
@AsafManela AsafManela deleted the dsmr branch May 8, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AsafManela