Fix failing tests on master
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arwalk
approved these changes
Dec 27, 2024
|
No worries, thanks again for writing this software! Apologizes in advance for being a pain, but is a version bump possible? It would probably be best for the packaged version to show passing tests. |
|
You're not a pain, you're being more serious than i am. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2 . This also fixes many of the
pytestwarnings from outdated/deprecated BeautifulSoup4 functions/arguments. I'm not super familiar with the library; please feel free to point out any inappropriate changes.I've also compared the
.epuboutput from themasterbranch and this branch. While they're not byte-for-byte equal, I've compared the outputs with a few different eBook readers and they seem to render identically in each one.