Fix "Unsaved ACL changes" promt not appearing

The introduction of the new modal component
broke the confirmation modal that appeared
when you had unsaved changes in your events
or series details access policy tab. Should now
be restored.

src/components/events/partials/modals/EventDetailsModal.tsx

@@ -34,7 +34,9 @@ const EventDetailsModal = () => {
 			setPolicyChanged(false);
 			dispatch(removeNotificationWizardForm());
 			hideModal();
+			return true;
 		}
+		return false;
 	};
 
 	return (

src/components/events/partials/modals/SeriesDetailsModal.tsx

@@ -31,7 +31,9 @@ const SeriesDetailsModal = ({
 		if (!policyChanged || confirmUnsaved()) {
 			setPolicyChanged(false);
 			dispatch(removeNotificationWizardForm());
+			return true;
 		}
+		return false;
 	};
 
 	return (

src/components/recordings/partials/RecordingsActionCell.tsx

@@ -30,10 +30,6 @@ const RecordingsActionCell = ({
 		deleteConfirmationModalRef.current?.close?.();
 	};
 
-	const hideRecordingDetails = () => {
-		recordingDetailsModalRef.current?.close?.()
-	};
-
 	const showRecordingDetails = async () => {
 		await dispatch(fetchRecordingDetails(row.name));
 
@@ -57,7 +53,6 @@ const RecordingsActionCell = ({
 			)}
 
 			<RecordingDetailsModal
-				close={hideRecordingDetails}
 				recordingId={row.name}
 				modalRef={recordingDetailsModalRef}
 			/>

src/components/recordings/partials/modal/RecordingDetailsModal.tsx

@@ -7,19 +7,16 @@ import { Modal, ModalHandle } from "../../../shared/modals/Modal";
  * This component renders the modal for displaying recording details
  */
 const RecordingDetailsModal = ({
-	close,
 	recordingId,
 	modalRef,
 }: {
-	close: () => void,
 	recordingId: string,
 	modalRef: React.RefObject<ModalHandle>
 }) => {
 	const { t } = useTranslation();
 
 	return (
 		<Modal
-			closeCallback={close}
 			header={t("RECORDINGS.RECORDINGS.DETAILS.HEADER", {
 				name: recordingId,
 			})}

src/components/shared/modals/Modal.tsx

@@ -10,7 +10,8 @@ import { useTranslation } from "react-i18next";
 
 export type ModalProps = {
 	open?: boolean
-	closeCallback?: () => void
+	// Having this return false will prevent the modal from closing
+	closeCallback?: () => boolean
 	/** If true, the first element in the modal automatically be focused. If false,
 	 * no element is initially focused */
 	initialFocus?: false | string
@@ -43,7 +44,10 @@ export const Modal = forwardRef<ModalHandle, PropsWithChildren<ModalProps>>(({
 		isOpen: () => isOpen,
 		open: () => setOpen(true),
 		close: () => {
-			closeCallback !== undefined && closeCallback();
+			if (closeCallback !== undefined && !closeCallback()) {
+				// Don't close modal
+				return;
+			}
 			setOpen(false);
 		},
 	}), [closeCallback, isOpen]);