We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug Game unpauses if it was paused before the console was opened.
To Reproduce Steps to reproduce the behavior:
Expected behavior Game pause state should never change when pause_if_input is false.
pause_if_input
false
Desktop (please complete the following information):
Additional context More specifically, this code in res://addons/panku_console/modules/interactive_shell/module.gd:
res://addons/panku_console/modules/interactive_shell/module.gd
if _is_gui_open and pause_if_input: _was_tree_paused = core.get_tree().paused core.get_tree().paused = true else: if core.get_tree().paused: core.get_tree().paused = _was_tree_paused
Never sets the correct value for _was_tree_paused because pause_if_input is always false. It should probably be something like this instead:
_was_tree_paused
if pause_if_input: if _is_gui_open: _was_tree_paused = core.get_tree().paused core.get_tree().paused = true else: if core.get_tree().paused: core.get_tree().paused = _was_tree_paused
Sorry, I don't have time to create a PR or check for unintended side effects of that change at the moment.
The text was updated successfully, but these errors were encountered:
Thanks for report, you solution seems good, no side effects I can see.
Sorry, something went wrong.
d3b241d
Merge pull request #205 from worron/fix_unwanted_unpause
d8eee0f
Fix unwanted game unpause (close #203)
worron
No branches or pull requests
Describe the bug
Game unpauses if it was paused before the console was opened.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Game pause state should never change when
pause_if_input
isfalse
.Desktop (please complete the following information):
Additional context
More specifically, this code in
res://addons/panku_console/modules/interactive_shell/module.gd
:Never sets the correct value for
_was_tree_paused
becausepause_if_input
is always false. It should probably be something like this instead:Sorry, I don't have time to create a PR or check for unintended side effects of that change at the moment.
The text was updated successfully, but these errors were encountered: