Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(llama_index)!: support 0.10.0 #201

Merged
merged 9 commits into from
Feb 13, 2024
Merged

feat(llama_index)!: support 0.10.0 #201

merged 9 commits into from
Feb 13, 2024

Conversation

mikeldking
Copy link
Contributor

@mikeldking mikeldking commented Feb 12, 2024 •
edited
Loading

resolves #200

Fixes llama-index instrumentation to work with breaking changes in imports

  • get mypy passing
  • get tests passing

@mikeldking mikeldking changed the title llama index 0 10 0 feat(llama_index)!: support 0.10.0 Feb 13, 2024
@mikeldking mikeldking marked this pull request as ready for review February 13, 2024 00:42
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 13, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 13, 2024
RogerHYang
RogerHYang requested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@RogerHYang RogerHYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we may be able to do this without a breaking change. let me take a crack at it

RogerHYang
RogerHYang approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@RogerHYang RogerHYang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind. it's not worth the effort. it's too messy

@mikeldking mikeldking merged commit b22b435 into main Feb 13, 2024
3 checks passed
@mikeldking mikeldking deleted the llama-index-0-10-0 branch February 13, 2024 20:36
This was referenced Feb 13, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RogerHYang RogerHYang RogerHYang approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Python] support llama-index 0.10.0
2 participants
@mikeldking @RogerHYang