Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: erroneous if statement #161

Merged
merged 2 commits into from
Feb 1, 2024
Merged

fix: erroneous if statement #161

merged 2 commits into from
Feb 1, 2024

Conversation

RogerHYang
Copy link
Contributor

No description provided.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 31, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 1, 2024
axiomofjoy
axiomofjoy approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@axiomofjoy axiomofjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID can be an empty list?

@RogerHYang
Copy link
Contributor Author

ID can be an empty list?

good point. converted to checking falsiness

@RogerHYang RogerHYang merged commit e92afc1 into main Feb 1, 2024
3 checks passed
@RogerHYang RogerHYang deleted the RogerHYang-patch-1 branch February 1, 2024 01:02
@github-actions github-actions bot mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axiomofjoy axiomofjoy axiomofjoy approved these changes

@mikeldking mikeldking mikeldking approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RogerHYang @mikeldking @axiomofjoy