-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add boto3 instrumentation #115
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels unexpected to place the implementation inside init.py. Any reason not to place it inside a client file?
python/instrumentation/openinference-instrumentation-boto/examples/boto_example.py
Outdated
Show resolved
Hide resolved
python/instrumentation/openinference-instrumentation-boto/examples/boto_example.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
build-backend = "hatchling.build" | ||
|
||
[project] | ||
name = "openinference-instrumentation-boto" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be called bedrock instead of boto?
name = "openinference-instrumentation-boto" | |
name = "openinference-instrumentation-bedrock" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good question, we are instrumenting bedrock
specifically but only for calls using the boto client. I'm leaning towards thinking bedrock
is better too, let me think about this a little bit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think let's leave the module as boto, since AWS may release more LLM functionality in the future that isn't specifically part of the Bedrock
service. I think we should change the instrumentor name to BedrockInstrumentor
though
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...tation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/__init__.py
Outdated
Show resolved
Hide resolved
...ntation/openinference-instrumentation-boto/src/openinference/instrumentation/boto/version.py
Outdated
Show resolved
Hide resolved
I think it's often seen if the implementation is small. I'll break it up as the complexity grows |
Resolves #33
Adds instrumentation for model calls via
boto3
Bedrock
client