Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inspector resize #794

Merged

Conversation

paulwarren-wk
Copy link
Contributor

Reason for change

Regression - no longer possible to resize the fact inspector by dragging the border between the inspector and viewer panes.

Description of change

Increase the z-order of the viewer pane. The resize relies on an invisible HTML element that overlaps the inspector pane by a few pixels. The regression occurred in e452daa which swapped the order of the viewer and inspector panes to make the tab order more intuitive. Unfortunately, this meant that overlapping element was now under the inspector pane and thus inaccessible.

Steps to Test

Confirm that the pane can now be resized.

review:
@Arelle/arelle
@paulwarren-wk

@paulwarren-wk paulwarren-wk requested a review from a team as a code owner January 8, 2025 22:23
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@austinmatherne-wk austinmatherne-wk merged commit 152352f into Arelle:master Jan 8, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants