Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rover4.4 builderror patch #29121

Open
wants to merge 2 commits into
base: Rover-4.4
Choose a base branch
from
Open

Rover4.4 builderror patch #29121

wants to merge 2 commits into from
+2 −2

Conversation

gsubmarine
Copy link

@gsubmarine gsubmarine mentioned this pull request Jan 21, 2025
Open
peterbarker
peterbarker approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we do not typically merge back into older branches.

I think we should in this case to make it easier for anyone stuck back there. But it is a decision for the maintainer/release manager

@gsubmarine
Copy link
Author

LGTM, but we do not typically merge back into older branches.

I think we should in this case to make it easier for anyone stuck back there. But it is a decision for the maintainer/release manager

Thanks @peterbarker. Looks like the CI Check for macos build is broken in the top of Rover-4.4. So no action on the CI?
Also, who is the release manager?

Need this fix for the sim build to work on linux, and to get this pr working: #24178

@gsubmarine
Copy link
Author

@rmackay9 do you have merge privileges?

@rmackay9
Copy link
Contributor

Hi @gsubmarine, yes I can merge this and I'm talking to @peterbarker about that..

@rmackay9
Copy link
Contributor

oh, we've got new commits now that need to be reviewed so I've removed the merge on CI pass

@rmackay9
Copy link
Contributor

Hi @gsubmarine, could you remove the commits intead of reverting them?

@gsubmarine gsubmarine force-pushed the Rover4.4_builderror_patch branch from 17c6163 to 45c9dad Compare January 25, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker approved these changes

@rmackay9 rmackay9 rmackay9 approved these changes

Assignees
No one assigned
Labels
4.4 Backport Rover
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gsubmarine @rmackay9 @peterbarker @acxz