-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix param Increment comment #29036
fix param Increment comment #29036
Conversation
Hi @Huibean, Thanks for this. It's looking pretty good but can you make these two changes?
Thanks! |
62ac32e
to
b73f1e6
Compare
@rmackay9 done, thanks for the correction! |
Where does this cause problems? There are a few other places in the code with a dot and no leading zero. |
https://discord.com/channels/674039678562861068/710994174299603055/1327151096380133396 |
Merged, thanks! |
If that is the standard the generator should probably normalize it. |
For number value is not hard to correct or report invalid, and in the text field just keep displaying the original content from xml |
fix param Increment comment for xml metadata use