Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix param Increment comment #29036

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

Huibean
Copy link
Member

@Huibean Huibean commented Jan 10, 2025

fix param Increment comment for xml metadata use

@Huibean Huibean requested a review from rmackay9 January 10, 2025 05:56
@rmackay9
Copy link
Contributor

Hi @Huibean,

Thanks for this. It's looking pretty good but can you make these two changes?

  1. split the commit into two, one affecting AP_AHRS and the other affecting AP_Mount
  2. rename the commits so that they start with the library name. E.g. "AP_AHRS: fix param increment description" and "AP_Mount: fix param increment description",

Thanks!

@Huibean Huibean force-pushed the pr-fix-param-Increment-comment branch from 62ac32e to b73f1e6 Compare January 10, 2025 06:35
@Huibean
Copy link
Member Author

Huibean commented Jan 10, 2025

@rmackay9 done, thanks for the correction!

@tpwrules
Copy link
Contributor

Where does this cause problems? There are a few other places in the code with a dot and no leading zero.

@peterbarker
Copy link
Contributor

Where does this cause problems? There are a few other places in the code with a dot and no leading zero.

https://discord.com/channels/674039678562861068/710994174299603055/1327151096380133396

image

@peterbarker peterbarker merged commit 0f8f2b2 into ArduPilot:master Jan 11, 2025
99 checks passed
@peterbarker
Copy link
Contributor

Merged, thanks!

@tpwrules
Copy link
Contributor

If that is the standard the generator should probably normalize it.

@Huibean
Copy link
Member Author

Huibean commented Jan 12, 2025

If that is the standard the generator should probably normalize it.

For number value is not hard to correct or report invalid, and in the text field just keep displaying the original content from xml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants