-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plane:mode AUTOLAND enhancements #28976
Conversation
0cc3cd5
to
3c10149
Compare
e462280
to
f722212
Compare
f722212
to
63417b3
Compare
2332cc5
to
a6b0ebc
Compare
Added loiter to alt with direct exit to landing final and moved option to AUTOLAND module... |
c5189fe
to
a5deff0
Compare
d58ca00
to
ceff3d0
Compare
8df7550
to
a3e5475
Compare
4d31767
to
7830bc9
Compare
7830bc9
to
cddeb74
Compare
@Hwurzburg @tridge I have done a PR to address the issues with loiter radius scaling, it does get quite bad at higher altitudes. In that messing about I have found two other issues. The first is pre-existing and that is what happens if you have ardupilot/ArduPlane/commands_logic.cpp Lines 29 to 37 in 230f824
Its looking in the mission at what the next command is, of course here were not in the mission so that will be nonsense. Maybe it would be enough to warp a check that were in auto for that bit. In the longer term it would be nice to rework more comprehensively so both mission and this could use a common base method. |
cddeb74
to
61edf4f
Compare
Added all of Pete Hall's changes to cope with high altitude |
Co-authored-by: Andrew Tridgell <andrew@tridgell.net> Co-authored-by: Pete Hall <iampete@hotmail.co.uk>
Co-authored-by: Andrew Tridgell <andrew@tridgell.net> Co-authored-by: Pete Hall <iampete@hotmail.co.uk>
Co-authored-by: Andrew Tridgell <andrew@tridgell.net> Co-authored-by: Pete Hall <iampete@hotmail.co.uk>
61edf4f
to
b7994c5
Compare
This PR enhances the new AUTOLAND mode. It adds the following new features:
Allows takeoff direction capture, and hence autoland direction and use, in ACRO, STABILIZE, FBWA, TRAINING, and MANUAL modes, in addition to Mode TAKEOFF and AUTO NAV_TAKEOFF, using the same criteria as currently used, the first time after arming.
Adds an AUTOLAND_OPTIONS option that will set this direction upon arming using a compass, if in use, instead of ground course, allowing the user to set it on the ground arbitrarily as desired, independent of the actual takeoff direction. The option is in the autoland module for future expansion
the "base" leg is actually a WP_LOITER_RAD loiter to alt with tangent exit directly into the final approach waypoint and landing with proper loiter direction.
changes to current behavior, besides the new features, is that once the direction is captured it persists until a disarm occurs. Therefore multiple auto takeoffs while armed no longer reset the direction captured by the first, on each subsequent takeoff. Originally, I thought this behavior was desirable, but I now believe it's not of much benefit and the new behavior avoids the current corner case issue of resetting the direction while in flight if a NAV_TAKEOFF autotakeoff is interrupted and then resumed. Also, this is not available for QudPlanes, even if fixed wing landing option is used. We thought the possibility of getting the direction inappropriately wrong on transitions from a VTOL takeoff just too complex to get correct.
In addition, it removes the AUTOLAND code segments in the commands_logic and mode_takeoff modules, reducing the flash impact overall...
These changes have been tested in SITL and flight-tested in all configurations I could think of.