Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP_Compass: add IIS2MDC driver #28602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AP_Compass: add IIS2MDC driver #28602

wants to merge 1 commit into from
+270 −1

Conversation

dakejahl
Copy link
Contributor

Adds a driver for the ST IIS2MDC magnetometer
https://www.st.com/resource/en/datasheet/iis2mdc.pdf

@dakejahl dakejahl mentioned this pull request Nov 13, 2024
Open
23 tasks
peterbarker
peterbarker requested changes Nov 13, 2024
View reviewed changes
libraries/AP_Compass/AP_Compass_IIS2MDC.cpp Outdated Show resolved Hide resolved
libraries/AP_Compass/AP_Compass_IIS2MDC.h Show resolved Hide resolved
libraries/AP_Compass/AP_Compass_IIS2MDC.h Outdated Show resolved Hide resolved
libraries/AP_Compass/AP_Compass_IIS2MDC.cpp Outdated Show resolved Hide resolved
libraries/AP_Compass/AP_Compass_IIS2MDC.cpp Outdated Show resolved Hide resolved
libraries/AP_Compass/AP_Compass_IIS2MDC.cpp Outdated Show resolved Hide resolved
libraries/AP_Compass/AP_Compass_IIS2MDC.h Outdated Show resolved Hide resolved
peterbarker
peterbarker requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fold the commits.

Please also outline the testing you've done.

@dakejahl
Copy link
Contributor Author

Please fold the commits.

Done. Should I do a separate commit for Tools/? I assumed a single commit since this PR should be atomic.

Please also outline the testing you've done.

Bench tested on the ARK FPV. I've uploaded the log file to Drive.

QGC
Screenshot from 2024-11-17 19-29-13
PlotJuggler
Screenshot from 2024-11-17 20-56-37

@dakejahl dakejahl force-pushed the pr-compass_iis2mdc branch 2 times, most recently from 553dc1f to 6750137 Compare November 19, 2024 01:19
@dakejahl
Copy link
Contributor Author

dakejahl commented Dec 2, 2024

@peterbarker can you let me know if there's anything else here you'd like to see?

@dakejahl
Copy link
Contributor Author

dakejahl commented Jan 7, 2025

Is there anything else needed to get this merged? The ARK FPV board support depends on it.

I've also uploaded a flight log in position mode demonstrating functionality
#28603 (comment)

peterbarker
peterbarker requested changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the minor include issue

libraries/AP_Compass/AP_Compass_IIS2MDC.h Outdated Show resolved Hide resolved
@dakejahl dakejahl force-pushed the pr-compass_iis2mdc branch from 6750137 to 8e744eb Compare January 8, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterbarker peterbarker peterbarker requested changes

Assignees
No one assigned
Labels
DevCallEU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dakejahl @peterbarker