-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_Compass: move param to table per instance #19123
Conversation
This one actually does save flash,
|
8061aea
to
7ee9355
Compare
I should probably add back the param descriptions for the old param names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change so I've approved it but I worry we will regret the impact on users.
Let's see what @meee1 says about the required MP changes before we merge this.
f837a5d
to
79bae52
Compare
@meee1 How much effort is it for mission planner to deal with these changes? |
need to ask @meee1 to do the MissionPlanner changes before we merge this. Also need to test with QGC. I think we should also check with UGCS |
i'll wait for @rmackay9 to be on a dev call for final decision |
Sorry I missed the call, it's a bit borderline but I"m ok with merging this. |
79bae52
to
09efd9e
Compare
09efd9e
to
7010937
Compare
I was looking at changing
COMPASS_MOTCT
for battery instances and decided that the whole compass param tree is a mess. So I have converted to a per instance table.The names have changes a little since the number has to come before the suffix.
Will need some GCS change to look for the new param names, I do think the naming is a improvement.
COMPASS1_
now gets you all compass 1 params rather than having to try and pick them out of the list maunaly.COMPASS_ENABLE
has also been moved to the top of the table and been given a enable flag.Once this is in I would like to move
COMPASS_MOTCT
to the new instance param so we can compensate different compasses for different things.