Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flightdata, Payload Control tab fixes #3153

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

rmackay9
Copy link
Contributor

@rmackay9 rmackay9 commented Jul 28, 2023

This fixes three issues I've found with the Payload Control tab

  • The tab appears/disappears based on whether a MAVLink enabled gimbal has been seen or not but most gimbals are not mavlink enabled meaning this tab is normally invisible at first. I've removed the logic to show/hide this tab and instead it is left to the user to use the Customise checkboxes.
  • The Roll scroll bar direction was reversed meaning a gimbal would roll in the opposite direction to what the user would expect
  • MOUNT_CONTROL messages have been replaced by MAV_CMD_MOUNT_CONTROL commands. This command has been accepted since 4.0 (perhaps much earlier).

This has been tested on my PC with a DJI RS2 gimbal (see AP user wiki here) running latest ArduPilot. I have not tested with older versions of AP but I think it should all work.

The only thing I was not able to test was the case where the GCS sends lat,lon,alt commands to the gimbal. I think what I've done is correct though and from what I can see though this feature is never used in any case.

@rmackay9 rmackay9 added the bug label Jul 28, 2023
@rmackay9 rmackay9 requested a review from meee1 July 30, 2023 23:36
@meee1 meee1 merged commit bd6d475 into ArduPilot:master Aug 3, 2023
@rmackay9
Copy link
Contributor Author

rmackay9 commented Aug 3, 2023

Thanks very much!

@rmackay9 rmackay9 deleted the payload-control-fixes branch August 3, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants