Fix getting settings default result #3103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new GetDecimal() helper but also it ensures the default value is returned when a TryParse() fails in the various helpers.
Current code assumes
TryParse(string, result)==false
does not touch result because we are initially setting the result with the default value and then always return the value without checking the return boolean. However, the docs say it will trample on result when returning false. Here's the docs for Int32.TryParse()