ConfigRawParams: fix typecast exception #3094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing a float param, the cell gets set to a double, instead of a string, which throws a typecase exception if the cell is edited and then "None Default" is clicked. I fix this on both ends, setting the cell to a string, and using ToString everywhere instead of typecasting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing a float param, the cell gets set to a double, instead of a string, which throws a typecase exception if the cell is edited and then "None Default" is clicked. I fix this on both ends, setting the cell to a string, and using
ToStringeverywhere instead of typecasting.The only part of this PR that is truly needed is the
ToStringon line 446, but it's too easy to make a similar mistake in the future and have it go unnoticed.