Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtLibs: Allow for special characters in NTRIP connection string #3035

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

stephendade
Copy link
Contributor

If a user's ntrip username or password has special characters (not letters or numbers), ie http://user1#:938aasd^!@ntrip.data.gnss.ga.gov.au:2101/TEST1 the URI string will not be properly encoded.

This PR allows for these special characters to be used, which is useful as some NTRIP providers are now enforcing password policies of requiring special characters.

@meee1
Copy link
Contributor

meee1 commented Jan 9, 2023

i havnt confirm the function
but wouldusing
WebUtility.UrlEncode(item.Value)
be an option?

@stephendade
Copy link
Contributor Author

WebUtility.UrlEncode(item.Value)

That encodes the whole string: http%3A%2F%2Fuser1%23%3A938aasd%5E!%40ntrip.data.gnss.ga.gov.au%3A2101%2FTEST1

@meee1 meee1 merged commit 8c9f116 into ArduPilot:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants