Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the low level of SEVERITY to speak #2979

Merged
merged 3 commits into from
Nov 15, 2022

Conversation

muramura
Copy link
Contributor

@muramura muramura commented Oct 14, 2022

I set the voice notification and HUD display level to NOTICE or higher.
There are some messages I would like to be notified about in the voice notification and HUD display.
I know that I am voice notified of NOTICE or above in QGC.
ArduPilot is notifying me of NOTICE level messages.
I think there is merit to have this message displayed on the HUD, with voice notification.

Other:.
The message display on the HUD uses red, yellow, and white colors to distinguish between emergency, warning, and other.

@muramura
Copy link
Contributor Author

I did an AUTOTUNE, saw that the aircraft went quiet, and looked at the MESSAGE tag to see what caused it.
I could see that ArduPilot was notifying me with NOTICE.
NOTICE is the audio notification level.
I would suggest that voice notification to the operator would be a good idea.

Screenshot from 2022-10-27 06-21-14

@meee1
Copy link
Contributor

meee1 commented Oct 26, 2022

can you make this a user selectable option?

@muramura
Copy link
Contributor Author

muramura commented Oct 27, 2022

I would add to the PLANNER configuration item.

I would change the speech item to allow a SEVERITY low level to be specified.
Change screen:
Screenshot from 2022-10-30 23-27-03

@muramura muramura force-pushed the MP_Talking_level_to_NOTICE_or_above branch from 1e80447 to 0d300e8 Compare October 30, 2022 22:03
@muramura muramura changed the title MavlinkInterface: Talking level to NOTICE or above Set the minimum level of SEVERITY to speak Oct 30, 2022
@muramura
Copy link
Contributor Author

I have made it possible to set a SEVERITY minimum level.

@@ -5221,7 +5221,7 @@ public async Task<MAVLinkMessage> readPacketAsync()
if (MAVlist[sysid, compidcurrent].cs.version.Major > 0 ||
MAVlist[sysid, compidcurrent].cs.version.Minor >= 4)
{
if (sev <= (byte)MAV_SEVERITY.WARNING)
if (sev <= (byte)Settings.Instance.GetInt32("severity"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add the default value. as if this has never been set by the user, it will results in a 0 atm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add processing-ization.

@muramura muramura force-pushed the MP_Talking_level_to_NOTICE_or_above branch from 0d300e8 to 1bf848e Compare November 2, 2022 00:34
@@ -5221,7 +5221,7 @@ public async Task<MAVLinkMessage> readPacketAsync()
if (MAVlist[sysid, compidcurrent].cs.version.Major > 0 ||
MAVlist[sysid, compidcurrent].cs.version.Minor >= 4)
{
if (sev <= (byte)MAV_SEVERITY.WARNING)
if (sev <= (byte)Settings.Instance.GetInt32("severity"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what i was suggesting was
Settings.Instance.GetInt32("severity", 4)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured. I will change my suggestion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made changes.

@muramura
Copy link
Contributor Author

muramura commented Nov 2, 2022

@muramura muramura force-pushed the MP_Talking_level_to_NOTICE_or_above branch from 1bf848e to a4f1a09 Compare November 2, 2022 15:33
@muramura muramura changed the title Set the minimum level of SEVERITY to speak Set the low level of SEVERITY to speak Nov 2, 2022
@meee1 meee1 merged commit 0f4c807 into ArduPilot:master Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants