-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set the low level of SEVERITY to speak #2979
Set the low level of SEVERITY to speak #2979
Conversation
can you make this a user selectable option? |
1e80447
to
0d300e8
Compare
I have made it possible to set a SEVERITY minimum level. |
@@ -5221,7 +5221,7 @@ public async Task<MAVLinkMessage> readPacketAsync() | |||
if (MAVlist[sysid, compidcurrent].cs.version.Major > 0 || | |||
MAVlist[sysid, compidcurrent].cs.version.Minor >= 4) | |||
{ | |||
if (sev <= (byte)MAV_SEVERITY.WARNING) | |||
if (sev <= (byte)Settings.Instance.GetInt32("severity")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add the default value. as if this has never been set by the user, it will results in a 0 atm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add processing-ization.
0d300e8
to
1bf848e
Compare
@@ -5221,7 +5221,7 @@ public async Task<MAVLinkMessage> readPacketAsync() | |||
if (MAVlist[sysid, compidcurrent].cs.version.Major > 0 || | |||
MAVlist[sysid, compidcurrent].cs.version.Minor >= 4) | |||
{ | |||
if (sev <= (byte)MAV_SEVERITY.WARNING) | |||
if (sev <= (byte)Settings.Instance.GetInt32("severity")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what i was suggesting was
Settings.Instance.GetInt32("severity", 4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured. I will change my suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made changes.
1bf848e
to
a4f1a09
Compare
I set the voice notification and HUD display level to NOTICE or higher.
There are some messages I would like to be notified about in the voice notification and HUD display.
I know that I am voice notified of NOTICE or above in QGC.
ArduPilot is notifying me of NOTICE level messages.
I think there is merit to have this message displayed on the HUD, with voice notification.
Other:.
The message display on the HUD uses red, yellow, and white colors to distinguish between emergency, warning, and other.