setPositionTargetGlobalInt: fix TYPE_MASK_FORCE handling #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build MissionPlanner 1.0.3036 completed (commit 5a01dd9bc6 by @hendjoshsr71) |
|
Looks straightforward enough, thanks Josh for fixing the issue so quickly. Looking forward to a new MP build :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the handling of setPositionTargetGlobalInt messages due to a recent change in ArduPilot master here to reject commands with FORCE set.
Tested by building MissionPlanner and moving around in SITL.
See Discuss post here
@rmackay9 Thoughts on changing this behavior in ArduPilot master to only reject commands where FORCE set is true and we are not ignoring acceleration commands?
With the behavior as we have it we could get more support requests for where people are setting the bit even though they weren't using it. Unfortunately, for the field the MAVLINK spec was a bit wonky.