Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue where extension would not load on sites #451

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

ItsANameToo
Copy link
Contributor

Summary

Odd issue, but the extension stopped working on sites like https://demo.arkconnect.io/ and https://live.arkscan.io/ with the release of chrome v130, throwing in error in devtools regarding Content Security Policy and it not wanting to load the content.js file. After a lot of configuration adjustments it seems to work with this small change where the content_scripts gets changed from purely https to both https and http.

Note that it only works when both are included. Having either https or http in itself will not allow the extension to work, but when the array contains both is magically works. The Firefox manifest remains as-is as it works fine there with just the https content scripts entry.

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@ItsANameToo ItsANameToo merged commit affe5cc into develop Nov 26, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the fix/chrome-manifest-issue branch November 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant