Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: disable qr upload button on firefox #445

Merged
merged 2 commits into from
Jul 19, 2024
Merged

refactor: disable qr upload button on firefox #445

merged 2 commits into from
Jul 19, 2024

Conversation

patricio0312rev
Copy link
Contributor

[QR Code] Disable Upload QR button on Firefox

Summary

  • QR Upload button is now disabled on Firefox.
  • A new tooltip will be displayed when hovering this disabled button.
image

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev changed the base branch from develop to rc-1.13.0 July 19, 2024 13:01
@patricio0312rev patricio0312rev added this to the 1.13.0 milestone Jul 19, 2024
@ItsANameToo ItsANameToo merged commit 40f36bc into rc-1.13.0 Jul 19, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the refactor/disable-qr-upload-on-firefox branch July 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItsANameToo ItsANameToo ItsANameToo approved these changes

Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@patricio0312rev @ItsANameToo