Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wallet already exists error page styles #444

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

patricio0312rev
Copy link
Contributor

[Errors] Wallet already exists page needs work

Summary

  • Styles for HTML inserted in error pages have been updated to prevent text being displayed horizontally.
image

Checklist

  • I checked that both pnpm dev and pnpm dev:bare work as intended
  • I checked the basic extension interactions and made sure wallet selection works
  • I checked my UI changes against the design and there are no notable differences, including responsiveness
  • I checked my (code) changes for obvious issues, debug statements and commented code
  • I opened a corresponding card on Clickup for any remaining TODOs in my code
  • I added a short description on how to test this PR (if necessary)
  • Ready to be merged

@patricio0312rev patricio0312rev changed the base branch from develop to rc-1.13.0 July 19, 2024 12:47
@patricio0312rev patricio0312rev added this to the 1.13.0 milestone Jul 19, 2024
@ItsANameToo ItsANameToo merged commit 3af5aa7 into rc-1.13.0 Jul 19, 2024
4 checks passed
@ItsANameToo ItsANameToo deleted the fix/wallet-already-exists-error-page branch July 19, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants