fix: adjust focus color for upload qr modal #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricio0312rev
commented
Jul 16, 2024
| @@ -138,9 +138,9 @@ export const UploadQRModal = ({ | |||
| maxSize={5} | |||
| onSizeError={handleSizeError} | |||
| onTypeError={handleTypeError} | |||
| tabIndex={-1} | |||
| classes='focus-within:!outline-theme-primary-600 rounded-2xl' | |||
There was a problem hiding this comment.
I am using focus-within and forcing the class name due to the library not allowing the management of tab index or overriding their styles.
ItsANameToo
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[QR] Upload QR Code button outline
Summary
Checklist
pnpm devandpnpm dev:barework as intended