Fix accidental globals and references to undeclared variables

[KiwiHawk]

Found by temporarily adding the following code to angelsrefining/data.lua

setmetatable(_G, {
  __newindex = function (_, n)
    error("attempt to write to undeclared variable "..n)
  end,
  __index = function (_, n)
    error("attempt to read undeclared variable "..n)
  end,
})

[LovelySanta]

Should 'similar' code be added to angels unit tests to log these kinds of errors?

[KiwiHawk]

Possibly. Personally, I would prefer if this check is a separate new mod. The missing recipe tints check could be part of that new mod too.

Reason being they are very different type of checks: data stage rather than control.

Mod load order is important. The metatable thing needs to be setup, ideally before any other mods run.

If we wanted some kind of summary printout to the log file, then we'll need two new mods. One that runs first (before any other mods) and the other runs last (after all other mods).

[LovelySanta]

I agree, the angelsdev-unit-test should run last (so all on_init stuff from other mods and the whole event dispatching order goes to other mods first prior to the unit tests)...

This can easily be done by adding hidden optional dependencies to the unit test mod to depend on all other (relevant) mods...
Then we need another small mod (I was thinking of angelsdev-unit-test-setup) that runs before other mods:

• For angels this is easy by adding a hidden optional dependency on the new mod.
• Add it as prerequisite to a minimal amount of bobmods?

The angelsdev-unit-test-setup should log on its own when the angelsdev-unit-test is present.

On a side note: checking data stage should also be done in angelsdev-unit-test as all mods must have had the chance of using data-final-fixes before we check it....

[KiwiHawk]

You can add reverse dependencies on other mods (for lack of a better term). This forces the other mod to load after. Prefix for this is ~. I remember reading about it but I've not been able to find any documentation on it.

This would be the ideal, as long as it can be made optional. Then all the dependencies could be in the new mod.

Otherwise yeah, it could be added as a hidden optional prerequisite to boblibrary.
Alternatively we could just rely on the alphanumeric sort order. Mod "AAAAAAAAAAAAA Test" should be loaded first, right?

This discussion should probably be moved to a separate, new issue though.

[KiwiHawk]

@LovelySanta I've created a new issue, logging your suggestion for new unit tests. So hopefully this PR can be merged now? :-)