-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sc rotation update #322
base: sc-rotation
Are you sure you want to change the base?
Sc rotation update #322
Conversation
yahgwai
commented
Nov 26, 2024
•
edited
Loading
edited
- checks that new member in rotation is not a nominee in the same way we already check for contender
- records the address that was rotated to to avoid race conditions in removal/replace
- incoming member can set an address that they will be updated to
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cherrypicked #328 for ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
feat: mid election rotation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, small comments; also PR described is not updated with the rotating to feature