Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sc rotation update #322

Open
wants to merge 41 commits into
base: sc-rotation
Choose a base branch
from
Open

Sc rotation update #322

wants to merge 41 commits into from

Conversation

yahgwai
Copy link
Collaborator

@yahgwai yahgwai commented Nov 26, 2024

  • checks that new member in rotation is not a nominee in the same way we already check for contender
  • records the address that was rotated to to avoid race conditions in removal/replace
  • incoming member can set an address that they will be updated to

@yahgwai yahgwai requested a review from gzeoneth November 26, 2024 11:58
@yahgwai yahgwai requested a review from godzillaba December 17, 2024 10:59
Copy link
Collaborator

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cherrypicked #328 for ci

@yahgwai yahgwai requested a review from gzeoneth February 6, 2025 13:09
Copy link
Collaborator

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yahgwai yahgwai requested a review from gzeoneth February 12, 2025 15:48
Copy link
Collaborator

@gzeoneth gzeoneth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small comments; also PR described is not updated with the rotating to feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants