Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing @export'ed in a box module means all are exported. #166

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

radbasa
Copy link
Collaborator

@radbasa radbasa commented Mar 21, 2025

Have you read the Contributing Guidelines?

Issue #165

Description

  • Added tests for attached modules
  • Changed behavior of unused_declared_object_linter() to assume all objects are exported if none are exported in the local file. This prevents the "declared function/object unused" lint.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
radbasa Ricardo Rodrigo Basa
@radbasa radbasa self-assigned this Mar 21, 2025
@radbasa radbasa requested a review from jakubnowicki March 21, 2025 09:51

Verified

This commit was signed with the committer’s verified signature.
radbasa Ricardo Rodrigo Basa
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.84%. Comparing base (1755be5) to head (2a00594).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #166   +/-   ##
=======================================
  Coverage   96.83%   96.84%           
=======================================
  Files          24       24           
  Lines        1170     1172    +2     
=======================================
+ Hits         1133     1135    +2     
  Misses         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Verified

This commit was signed with the committer’s verified signature.
radbasa Ricardo Rodrigo Basa
@radbasa radbasa linked an issue Mar 26, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support {box} export all if none are exported
1 participant