Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add news details page #928

Merged
merged 18 commits into from
Feb 26, 2024
Merged

Add news details page #928

merged 18 commits into from
Feb 26, 2024

Conversation

camillebrulotte
Copy link
Contributor

⁉️ Related Issue

Tâche dans notre projet jira.

📖 Description

En tant qu'utilisateur de l'application ÉTSMobile,
Je veux visualiser les détails des annonces.

🧪 How Has This Been Tested?

Added a couple of tests.

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.
  • Make sure golden files changes were reviewed and approved.

🖼️ Screenshots (if useful):

image image image image

@camillebrulotte camillebrulotte self-assigned this Feb 12, 2024
@camillebrulotte camillebrulotte requested a review from a team as a code owner February 12, 2024 00:57
@github-actions github-actions bot added size: L and removed size: XL labels Feb 12, 2024
HugoMigner
HugoMigner reviewed Feb 14, 2024
View reviewed changes
lib/core/constants/report_news.dart
title: "Contenu inapproprié",
description:
"Annonce contenant des discours haineux, des images choquantes, ou du contenu adulte.",
),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'il faudrait localiser ces messages aussi? 😮 Ou pour l'instant on les fait juste en FR

Copy link
Contributor Author

@camillebrulotte camillebrulotte Feb 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enfait je pensais qu'on allait les fetchs du backend au cas où que ça change mais pas certaine ! 😮

@MysticFragilist

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non en fait ce que je voulais dire c'est si on le faisait avec Firebase comme Sam avait fait dans les quicklinks comme ça on peut facilement les changer mais je sais pas comment il a fait .. @MysticFragilist

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouaiis on se rajouteras une tâche pour ça sinon c'est sûr on oublie hahaha je fais ça live

HugoMigner
HugoMigner approved these changes Feb 14, 2024
View reviewed changes
Copy link
Contributor

@HugoMigner HugoMigner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Petit comment et LGTM !

Udito3
Udito3 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@Udito3 Udito3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Après le commentaire d'hugo LGTM!

@Udito3 Udito3 merged commit 8c1805e into hello/master Feb 26, 2024
5 of 6 checks passed
@Udito3 Udito3 deleted the feature/hello/news-details-page branch February 26, 2024 00:54
XavierPaquet-Rapold added a commit that referenced this pull request Jun 3, 2024
@XavierPaquet-Rapold @Udito3
@clubapplets-server @apomalyn @camillebrulotte @MysticFragilist @mataai
Hello/master (#981)
716f90c 
* Migrate service classes to null safety

* Migrate constants to null safety

* Migrate utils to null safety

* Remove late from GetIt

* Change @required to required

* Migrate models to null safety

* Migrate main to null safety

* Migrate managers to null safety

* Migrate ViewModels to null safety

* Migrate utils to null safety

* Migrate views to null safety

* Migrate Views to null safety

* Migrate mocks to null safety

* Use late for all tests

* Fix service tests

* Migrate helpers to null safety

* Migrate managers tests to null safety

* Migrate ViewModel tests to null safety

* Managers use mocks for managers

* Migrate widget tests to null safety

* Migrate views tests to null safety

* Fix course_repository_test

* Fix QuickLinkRepository tests

* Fix SettingsManagerTests

* Fix user repository tests

* Fix GradeEvaluationTile tests

* Fix code problems

* Fix DashboardViewModel tests

* Fix FeedbackViewModelTest

* Fix GradeViewModel tests

* Fix UserRepositoryMock tests

* Fix ScheduleSettingsViewModel tests

* Fix ScheduleViewModel tests

* Fix GradeDetailsView tests

* Fix NotFoundView test

* Fix GradeDetailsViewModel tests

* Fix ScheduleViewModel tests

* Merge branch 'master' into hello/master

* Migrate service classes to null safety

* Migrate constants to null safety

* Migrate utils to null safety

* Remove late from GetIt

* Change @required to required

* Migrate models to null safety

* Migrate main to null safety

* Migrate managers to null safety

* Migrate ViewModels to null safety

* Migrate utils to null safety

* Migrate views to null safety

* Migrate Views to null safety

* Migrate mocks to null safety

* Use late for all tests

* Fix service tests

* Migrate helpers to null safety

* Migrate managers tests to null safety

* Migrate ViewModel tests to null safety

* Managers use mocks for managers

* Migrate widget tests to null safety

* Migrate views tests to null safety

* Fix course_repository_test

* Fix QuickLinkRepository tests

* Fix SettingsManagerTests

* Fix user repository tests

* Fix GradeEvaluationTile tests

* Fix code problems

* Fix DashboardViewModel tests

* Fix FeedbackViewModelTest

* Fix GradeViewModel tests

* Fix UserRepositoryMock tests

* Fix ScheduleSettingsViewModel tests

* Fix ScheduleViewModel tests

* Fix GradeDetailsView tests

* Fix NotFoundView test

* Fix GradeDetailsViewModel tests

* Remove use of Future OnError

* Fix ScheduleViewModel tests

* Ajouter un skeleton pendant le chargement des nouvelles dans ÉTSMobile (#927)

* WIP

* Skeleton

* Fixing tests WIP

* Fix test

* Skeleton test

* Clean imports

* [BOT] Applying version.

* [BOT] Applying format.

* Added nbSkeleton

---------

Co-authored-by: Udito3 <Udito3@users.noreply.github.com>
Co-authored-by: clubapplets-server <clubapplets-server@users.noreply.github.com>

* chore: Garbage commit to fix all errors, hint, and warnings.
Also bumping all dependencies

refs: #68

* Add news details page (#928)

* WIP

* Merge null safety

* Skeleton

* Fixing tests WIP

* Fix test

* Skeleton test

* Clean imports

* [BOT] Applying version.

* [BOT] Applying format.

* Fix test

* WIP

* Test done

* Merge

* Merge

* Remove unecessary comments

---------

Co-authored-by: Antoine Martineau <martineau.antoin3@gmail.com>
Co-authored-by: Udito3 <Udito3@users.noreply.github.com>
Co-authored-by: clubapplets-server <clubapplets-server@users.noreply.github.com>

* Remove use of Future OnError

* Fix ScheduleSettingTest tests

* Fix DashboardViewModelTest tests

* test: Fix settings loading issue

refs: #68

* test: Fix settings loading issue

refs: #68

* test: Remove useless test

refs: #68

* Fix ScheduleViewModel marker not appearing

* Migrate service classes to null safety

* Migrate constants to null safety

* Migrate utils to null safety

* Remove late from GetIt

* Change @required to required

* Migrate models to null safety

* Migrate main to null safety

* Migrate managers to null safety

* Migrate ViewModels to null safety

* Migrate utils to null safety

* Migrate views to null safety

* Migrate Views to null safety

* Migrate mocks to null safety

* Use late for all tests

* Fix service tests

* Migrate helpers to null safety

* Migrate managers tests to null safety

* Migrate ViewModel tests to null safety

* Managers use mocks for managers

* Migrate widget tests to null safety

* Migrate views tests to null safety

* Fix course_repository_test

* Fix QuickLinkRepository tests

* Fix SettingsManagerTests

* Fix user repository tests

* Fix GradeEvaluationTile tests

* Fix code problems

* Fix DashboardViewModel tests

* Fix FeedbackViewModelTest

* Fix GradeViewModel tests

* Fix UserRepositoryMock tests

* Fix ScheduleSettingsViewModel tests

* Fix ScheduleViewModel tests

* Fix GradeDetailsView tests

* Fix NotFoundView test

* Fix GradeDetailsViewModel tests

* Fix ScheduleViewModel tests

* Remove use of Future OnError

* Fix ScheduleSettingTest tests

* test: Fix settings loading issue

refs: #68

* Fix DashboardViewModelTest tests

* test: Fix settings loading issue

refs: #68

* test: Remove useless test

refs: #68

* Fix ScheduleViewModel marker not appearing

* Fix courses not appearing when no review

* Update CI and documentation

* [BOT] Applying version.

* [BOT] Applying format.

* Fix analyze

* chore: Apply merge

refs: #68

* Fix Golden

* [BOT] Applying format.

* Update pumpAndSettle duration

* chore: Upgrade dep

refs: #68

* [BOT] Update golden files

* chore: Upgrade dep

refs: #68

* Fix workflows

* fix: Adjust icon color

refs: #68

* fix: Adjust icon color

refs: #68

* Try to fix grades_details_view_test golden

* [BOT] Applying format.

* Try fixing grade_details_view_test

* Fix course evaluation bug and set appVersion

* [BOT] Applying format.

* UI fixes

* fix build tools version

* Add analytics

* Chang log

* Add analytics

* Light theme news details (#940)

* Dark/light theme news details

* [BOT] Applying version.

* Update news_details_view.dart

---------

Co-authored-by: Udito3 <Udito3@users.noreply.github.com>

* fix font

* use copyWith instead to prevent overcharging the default color for each theme

* fix schedule

* fix tests and some ui bug

* retrigger CI

* [BOT] Applying version.

* fix  CI

* fix analyse

* format all files

* update java version to 17 and use a recommended java distribution adopt->temurin

* fix some goldens

* [BOT] Applying format.

* remove unused import

* fix some more tests

* fix grades views test

* Hello - Handle different start/end date scenarios (#934)

* Added end event date

* Golden skip test

* Update news_details_view.dart

* [BOT] Applying version.

---------

Co-authored-by: Udito3 <Udito3@users.noreply.github.com>

* fix some issues

* merge hello master

* fix some problems after merge

* small fixes

* [Hello] News infinite scroll (#937)

* first draft infinite scroll

* fix infinite scroll

* petit fix pour mon bibi pref

* fix organizer

* fix news

* news card

* add first draft of loader for news

* fix news card loading image effect

* Add news tests and fix other that weren't working properly

* fix news

* fix comment trad

* Bump to tag version of ETS-API-CLient

* use patch version of 1.1 in ets api client

* fix flutter version

* fix flutter version in ci p2

* Hello - Author view (#933)

* WIP

* Merge null safety

* Skeleton

* Fixing tests WIP

* Fix test

* Skeleton test

* Clean imports

* [BOT] Applying version.

* [BOT] Applying format.

* Fix test

* WIP

* Test done

* Merge

* Merge

* Remove unecessary comments

* first draft infinite scroll

* Author info done

* Adding fake news to the author page

* missing test

* fix infinite scroll

* Force link order and adjust light theme

* Clean import

* Fix old test

* Added skeleton to author

* author view test

* Create author_viewmodel_test.dart

* Authorskeleton test

* test done

* Merge

* Organize imports

* petit fix pour mon bibi pref

* fix organizer

* fix news

* news card

* add first draft of loader for news

* fix news card loading image effect

* update golden

* Update social_links_card.dart

* Add news tests and fix other that weren't working properly

* fix news

* fix comment trad

* Bump to tag version of ETS-API-CLient

* Merge branch 'hello/master' into hello/feature/share-export

* merge

* Fix status

* WIP

* WIP

* Update author_view.dart

* [BOT] Applying version.

* Fix test

* Update pubspec.yaml

---------

Co-authored-by: Udito3 <Udito3@users.noreply.github.com>
Co-authored-by: clubapplets-server <clubapplets-server@users.noreply.github.com>
Co-authored-by: Camille Brulotte <camille.brulotte@icloud.com>
Co-authored-by: MysticFragilist <mont.samuel@outlook.com>

* Hello/feature/share export (#953)

* Ajout code programe baccalaureat informatique distribuée

* define program by the number of registered credits

* Sort list entries to have main program first.

* Add native requirements for calendar interactions

* Version that used to work

* test custom plugin

* update android files to fix build

* update native calendar even creation to fix creation bug

* comments

* comments

* Add calendar selection widget and update export method signature to specify selected calendar

* Add calendar translations

* WIP

* Merge null safety

* Skeleton

* Fixing tests WIP

* Fix test

* Skeleton test

* Clean imports

* [BOT] Applying version.

* [BOT] Applying format.

* Fix test

* WIP

* Test done

* Merge

* Merge

* Remove unecessary comments

* first draft infinite scroll

* Author info done

* Adding fake news to the author page

* missing test

* fix infinite scroll

* Force link order and adjust light theme

* Clean import

* Fix old test

* fix translations + existing event update.

* Added skeleton to author

* Add calendar export feedback + icon updated

* [BOT] Applying version.

* remove unused imports

* [BOT] Update golden files

* [BOT] Applying pod update.

* author view test

* Create author_viewmodel_test.dart

* Authorskeleton test

* test done

* Merge

* Organize imports

* Added end event date

* Golden skip test

* Update news_details_view.dart

* [BOT] Applying version.

* Menu

* Update news_details_view.dart

* petit fix pour mon bibi pref

* fix organizer

* fix news

* news card

* add first draft of loader for news

* fix news card loading image effect

* merge

* WIP

* Export calendar

* Toast color

* Share

* update golden

* Update social_links_card.dart

* Add news tests and fix other that weren't working properly

* fix news

* fix comment trad

* Bump to tag version of ETS-API-CLient

* Merge branch 'hello/master' into hello/feature/share-export

* merge

* Fix status

* WIP

* WIP

* WIP

* Update news_details_view.dart

* Update author_view.dart

* [BOT] Applying version.

* Fix test

* Update pubspec.yaml

* Update report_news.dart

* [BOT] Applying version.

* Added todo

---------

Co-authored-by: HandsomeRomanian <mat4school@gmail.com>
Co-authored-by: Udito3 <Udito3@users.noreply.github.com>
Co-authored-by: clubapplets-server <clubapplets-server@users.noreply.github.com>
Co-authored-by: Camille Brulotte <camille.brulotte@icloud.com>
Co-authored-by: MysticFragilist <mont.samuel@outlook.com>
Co-authored-by: mataai <mataai@users.noreply.github.com>

* Get organizer events for Author view (#961)

* WIP

* Load organizator info and news from backend

* Avatar

* Fix tests

* Self review

* Update pubspec.lock

* Update author_view.dart

* Report news (#963)

* WIP

* Load organizator info and news from backend

* Avatar

* Fix tests

* Self review

* Update pubspec.lock

* Update author_view.dart

* Report news

* Fix test

* Update pubspec.lock

* Comment hugo

* Hello/feature/search news (#964)

* Search bar

* Search and scroll back to today

* Light theme

* Search done

* FAB

* Activity area

* Circle avatar

* Padding

* Markdown

* Mardown

* Share news

* [BOT] Applying format.

* Add hello feature toggle

* [BOT] Applying format.

* Fix tests

* Fix analyze

* [BOT] Applying format.

* Fix code issues

* [BOT] Applying format.

* Fix a test

* [BOT] Update golden files

* [BOT] Applying pod update.

* Setup hello api remote config

* Fix tests

* [BOT] Applying format.

* Fix test

* [BOT] Update golden files

* [BOT] Applying pod update.

* [BOT] Applying version.

* Update l10n/intl_en.arb

Co-authored-by: Samuel Montambault <mont.samuel@outlook.com>

* Update l10n/intl_en.arb

Co-authored-by: Samuel Montambault <mont.samuel@outlook.com>

* Update l10n/intl_fr.arb

Co-authored-by: Samuel Montambault <mont.samuel@outlook.com>

* Update release-workflow.yaml

---------

Co-authored-by: Antoine Martineau <martineau.antoin3@gmail.com>
Co-authored-by: Antoine Martineau <47289926+Udito3@users.noreply.github.com>
Co-authored-by: Udito3 <Udito3@users.noreply.github.com>
Co-authored-by: clubapplets-server <clubapplets-server@users.noreply.github.com>
Co-authored-by: apomalyn <chretienxavier42@gmail.com>
Co-authored-by: Camille Brulotte <37625944+camillebrulotte@users.noreply.github.com>
Co-authored-by: XavierPaquet-Rapold <XavierPaquet-Rapold@users.noreply.github.com>
Co-authored-by: MysticFragilist <mont.samuel@outlook.com>
Co-authored-by: MysticFragilist <MysticFragilist@users.noreply.github.com>
Co-authored-by: Camille Brulotte <camille.brulotte@icloud.com>
Co-authored-by: HandsomeRomanian <mat4school@gmail.com>
Co-authored-by: mataai <mataai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MysticFragilist MysticFragilist MysticFragilist left review comments

@Udito3 Udito3 Udito3 approved these changes

@HugoMigner HugoMigner HugoMigner approved these changes

Assignees

@camillebrulotte camillebrulotte

Labels
size: L version: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@camillebrulotte @MysticFragilist @Udito3 @HugoMigner @clubapplets-server