Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update french README #826

Merged
merged 1 commit into from
Jul 15, 2023

Conversation

lol3909
Copy link
Contributor

@lol3909 lol3909 commented Jul 15, 2023

⁉️ Related Issue

No related issue

📖 Description

The french README wasn't updated. I updated the doc according to the english version.

🧪 How Has This Been Tested?

I look at the english README and compared it to the french README

☑️ Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • If needed, I added analytics.
  • Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.
  • Make sure golden files changes were reviewed and approved.

🖼️ Screenshots (if useful):

no screenshots

@lol3909 lol3909 requested a review from a team as a code owner July 15, 2023 20:01
@lol3909 lol3909 changed the title chore: update FR readme chore: update french README Jul 15, 2023
@lol3909
Copy link
Contributor Author

lol3909 commented Jul 15, 2023

Do I really need to create an issue for this? 😅

@MysticFragilist
Copy link
Contributor

@lol3909 Thanks for this, was a while since I've updated it! 😄 don't worry about the issue for that!

@MysticFragilist
Copy link
Contributor

Will merge it right away, pipeline is skipped on ".md" files anyway! Thanks again for your contribution! Feel free to check issues if you want to contribute more 😄 Or, if you want to have branch access to this repo you can join ApplETS, we do a meeting every week to help advance our projects :) https://clubapplets.ca/contact

@MysticFragilist MysticFragilist merged commit 830be4e into ApplETS:master Jul 15, 2023
@lol3909 lol3909 deleted the chore/update-fr-readme branch July 15, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants