Fix course evaluation bug and set appVersion

ApplETS · Mar 12, 2024 · 56a2a38 · 56a2a38
1 parent a40edc4
commit 56a2a38
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/core/managers/course_repository.dart b/lib/core/managers/course_repository.dart
@@ -510,8 +510,11 @@ class CourseRepository {
   /// Get the evaluation for a course or null if not found.
   CourseReview? _getReviewForCourse(
       Course course, Map<String, List<CourseReview>> reviews) {
+    // Todo: changer pour firstWhereOrNull après update de Collection
     final review = reviews[course.session]?.where((element) =>
-        element.acronym == course.acronym && element.group == course.group);
-    return review?.length == 1 ? review?.first : null;
+    element.acronym == course.acronym && element.group == course.group);
+    return review?.isNotEmpty ?? false
+        ? review?.first
+        : null;
   }
 }
diff --git a/lib/core/viewmodels/more_viewmodel.dart b/lib/core/viewmodels/more_viewmodel.dart
@@ -60,7 +60,8 @@ class MoreViewModel extends FutureViewModel {
   Future futureToRun() async {
     try {
       setBusy(true);
-      await PackageInfo.fromPlatform();
+      final packageInfo = await PackageInfo.fromPlatform();
+      _appVersion = packageInfo.version;
     } catch (error) {
       onError(error);
     } finally {