-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode build is not licensed under MIT #82
Comments
Hi Brenton, do you want me to remove the AppImage? I had asked for permission in Thanks, Am Freitag, 2. September 2016 schrieb Brenton Horne :
|
Nope, I was hoping you could write a Prefs file that will build an AppImage from VSCode's source code, which would make it MIT-Licensed. |
Perhaps @joaomoreno will have a look at it, microsoft/vscode#10857 (comment) - I am happy to help. |
Anything new about this issue? Why we don't have an internal build script. |
Theoretically you could create a repository that builds VSCode from source code (specifically the open-source build) and builds an AppImage from the build artefacts. You need to install the set of build dependencies like Node.js, NPM, gulp, gcc, g++, make, etc. after that you run: scripts/npm.sh install
node --max_old_space_size=2048 /usr/bin/gulp vscode-linux-x64 from the top-level of VSCode's source code directory (extracted from the source code tarballs of each release). Then copy the contents of the resulting VSCode-linux-x64 directory to your AppImage. |
@fusion809 Thanks for your response. 🙏 |
If you're talking about the upstream repo Microsoft/vscode, well you'll have to ask there if they'd be willing to keep a build script there. |
@fusion809 I see. Thank you so much. 🙏 |
Now my attempt to build an AppImage from Visual Studio Code (OSS) using Travis CI has failed, I reported it at microsoft/vscode#17013. |
I got it working FTW. If you wanna download it and give it a try see my Code-OSS.AppImage's continuous tag. |
https://flathub.org/apps/details/com.visualstudio.code has it, with full branding and everything. So I assume we are allowed to do the same in AppImage format? Using https://github.com/AppImage/pkg2appimage/blob/master/recipes/VSCode.yml it is trivially easy to make an AppImage. |
Hi,
The VSCode AppImage is not licensed under the MIT License, because it is built from the binary releases provided by Microsoft, which are licensed under a proprietary End-User License Agreement (EULA). If the AppImage was built from VSCode's source code, then it would be licensed under MIT (as its source code is MIT Licensed), but as it is built from Microsoft's binary releases it is governed by the license of these binary releases.
Thanks for your time,
Brenton
The text was updated successfully, but these errors were encountered: