Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

safer database content opt in #454

Merged
merged 2 commits into from
Aug 17, 2021
Merged

safer database content opt in #454

merged 2 commits into from
Aug 17, 2021

Conversation

redreceipt
Copy link
Member

the other way doesn't work like i'd hoped with upgrades because the config file is patched from templates and then its confusing why the app isn't working. this is just temporary, soon all apps will use database content anyway, and we won't need this opt in. maybe can drop it for v3 when DB is required.

the other way doesn't work like i'd hoped with upgrades because the config file is patched from templates and then its confusing why the app isn't working. this is just temporary, soon all apps will use database content anyway, and we won't need this opt in. maybe can drop it for v3 when DB is required.
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #454 (8094815) into master (14ac8c6) will not change coverage.
The diff coverage is n/a.

❗ Current head 8094815 differs from pull request most recent head 0084ee5. Consider uploading reports for the commit 0084ee5 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #454   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files           7        7           
  Lines         126      126           
  Branches       27       27           
=======================================
  Hits           74       74           
  Misses         50       50           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14ac8c6...0084ee5. Read the comment docs.

@vinnyjth
Copy link
Member

I was afraid that would be an issue :/

@redreceipt redreceipt enabled auto-merge (squash) August 17, 2021 19:50
@redreceipt redreceipt merged commit a3b6598 into master Aug 17, 2021
@redreceipt redreceipt deleted the databasecontent branch August 17, 2021 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants