Skip to content
This repository has been archived by the owner on Jan 16, 2022. It is now read-only.

chore: Stop running migrations automatically, run migrations by hand. #452

Merged
merged 11 commits into from
Aug 17, 2021

Conversation

vinnyjth
Copy link
Member

Steps to test

  1. Make sure you are pointed at your local database schema (not production)
  2. From the API folder, run yarn migrator down
  3. Boot the API, look for a special message telling you that you have migrations to run
  4. Run yarn migrator up.
    5 Confirm that migrations were ran.

Also note commands like yarn migrator --help

@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #452 (f541266) into master (4e284b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #452   +/-   ##
=======================================
  Coverage   58.73%   58.73%           
=======================================
  Files           7        7           
  Lines         126      126           
  Branches       27       27           
=======================================
  Hits           74       74           
  Misses         50       50           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e284b6...f541266. Read the comment docs.

@nlewis84
Copy link
Contributor

Could we put in some regex that would require the database URL variable to start with "http://localhost:"? And throw a warning to switch the variable.

@redreceipt
Copy link
Member

Could we put in some regex that would require the database URL variable to start with "http://localhost:"? And throw a warning to switch the variable.

don't love that because we may use copies or staging DBs at some point. it's really just protecting the prod DB we're concerned about.

@vinnyjth
Copy link
Member Author

@redreceipt added some documentation to the readme

README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -82,8 +82,7 @@ heroku open

To get started with different API integrations, check out our [docs](https://apollosapp.io)!

####
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agh you beat me to it!

@redreceipt redreceipt self-requested a review August 17, 2021 14:21
@redreceipt redreceipt enabled auto-merge (squash) August 17, 2021 14:40
@redreceipt redreceipt merged commit 14ac8c6 into master Aug 17, 2021
@redreceipt redreceipt deleted the make-migrations-great-again branch August 17, 2021 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants