removes events #430
removes events #430
Conversation
redreceipt
commented
Jul 14, 2021
•
blocked on https://github.com/ApollosProject/apollos-apps/pull/2063 being in a release
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
===========================================
- Coverage 58.73% 45.65% -13.08%
===========================================
Files 7 3 -4
Lines 126 92 -34
Branches 27 18 -9
===========================================
- Hits 74 42 -32
+ Misses 50 48 -2
Partials 2 2 Continue to review full report at Codecov.
|
| @@ -109,11 +108,6 @@ const App = () => ( | |||
| stackPresentation: 'push', | |||
| })} | |||
| /> | |||
| <Screen | |||
| name="Event" | |||
There was a problem hiding this comment.
should we put in a redirect from Event to content? I know if you try to navigate to a route that doesn't exist, you'll get an app crash
|
Why/how would people navigate to events?
…Sent from my iPhone
On Aug 17, 2021, at 5:47 PM, Conrad VanLandingham ***@***.***> wrote:
@conrad-vanl commented on this pull request.
In apolloschurchapp/src/index.js:
> @@ -109,11 +108,6 @@ const App = () => (
stackPresentation: 'push',
})}
/>
- <Screen
- name="Event"
should we put in a redirect from Event to content? I know if you try to navigate to a route that doesn't exist, you'll get an app crash
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
They had an event opened before they upgraded to this version of the app I'm happy approving without this change....I was hoping react-navigation had an easy way to do redirects...... |
|
Oh yea valid. I think those are pretty rare cases but could happen maybe, I’d rather figure out how to silently fail.
…Sent from my iPhone
On Aug 17, 2021, at 5:51 PM, Conrad VanLandingham ***@***.***> wrote:
They had an event opened before they upgraded to this version of the app
The API had an event as the action to link to (like in a feature) and either the app had cached content or the api wasn't properly updated
A push notification was sent out with /event in the url
I'm happy approving without this change....I was hoping react-navigation had an easy way to do redirects......
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
@conrad-vanl react-navigation 6 has built-in deep link support complete with a catch-all that we should probably move to. But I don't it's worth waiting on this PR considering I believe Willow is the only app that uses official events. |