Make metanetkan's version overrides more specific #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @dbent,
We wanted to make netkan's compatibility overrides work more like how it handles AVC so we could mix overrides with data from SpaceDock, see KSP-CKAN/CKAN#3265. Unfortunately, that broke this mod's metanetkan; it now has a minimum version of 1.0.2 instead of 1.3.0, because all of the overrides match the latest version, and if you apply all of those compatibility changes AVC-style, you end up with compatibility with basically all versions:
Fortunately, the spec has an easy way to fix this! Now the overrides have both a minimum and maximum version, so only one override will match each version.
Sorry for the inconvenience!