allow overriding the session object to pass customized ones #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Apr 11, 2023
| @@ -72,7 +73,7 @@ def __init__(self, **kwargs): | |||
| self.apidoc_cache_dir = kwargs.get('apidoc_cache_dir', apidoc_cache_dir_default) | |||
| self.apidoc_cache_name = kwargs.get('apidoc_cache_name', self._find_cache_name()) | |||
|
|
|||
| self._session = requests.Session() | |||
| self._session = kwargs.get('session') or requests.Session() | |||
There was a problem hiding this comment.
Do you use or here to make it lazy? I think this would always instantiate a session, even if one was passed.
Suggested change
| self._session = kwargs.get('session') or requests.Session() | |
| self._session = kwargs.get('session', requests.Session()) |
There was a problem hiding this comment.
Nah, mostly because I am lazy myself ;)
There was a problem hiding this comment.
But you're right, the one is lazy, the other is not:
>>> a ={'lol': 'what'}
>>> a.get('lol', whaaaa)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
NameError: name 'whaaaa' is not defined
>>> a.get('lol') or whaaaa
'what'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.