Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ruby 3.4.0-preview1 #929

Merged
merged 2 commits into from
May 28, 2024

Conversation

m-nakamura145
Copy link
Contributor

@m-nakamura145 m-nakamura145 commented May 24, 2024

This Pull Request adds support for Ruby 3.4.0-preview1. Running the current code with Ruby 3.4.0-preview1 results in the following error:

An error occurred while loading ./spec/lib/validators/array_validator_spec.rb. - Did you mean?
                    rspec ./spec/lib/apipie/validator_spec.rb

Failure/Error: require "action_controller/railtie"

LoadError:
  cannot load such file -- bigdecimal
# ./spec/dummy/config/application.rb:3:in '<top (required)>'
# ./spec/dummy/config/environment.rb:5:in '<top (required)>'
# ./spec/spec_helper.rb:10:in '<top (required)>'
# ./spec/lib/validators/array_validator_spec.rb:1:in '<top (required)>'

The reason for this error is that in Rails 7.0.X, bigdecimal is not added to the Gemfile (ref: Rails PR #49039). Therefore, for Ruby 3.4 and above, we need to use Rails 7.1.X for testing.

@mathieujobin
Copy link
Collaborator

The reason for this error is that in Rails 7.0.X, bigdecimal is not added to the Gemfile (ref: rails/rails#49039). Therefore, for Ruby 3.4 and above, we need to use Rails 7.1.X for testing.

I think we should also add bigdecimal at least in development dependencies of this gem

@mathieujobin mathieujobin merged commit 4b464be into Apipie:master May 28, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants