Recognize Rack Symbols as Status Codes #468
Conversation
|
👍 Would love to see this merged in. I prefer Rack codes since I think it makes your code much clearer! I usually can't remember all of the number codes and their meanings. |
lib/apipie/error_description.rb
Outdated
| attr_reader :code, :description, :metadata | ||
|
|
||
| class UnrecognizedCode < Exception |
There was a problem hiding this comment.
We have all other errors at one place her https://github.com/Apipie/apipie-rails/blob/296c097f9acb951149d3a67db69b84eb216bdd7e/lib/apipie/errors.rb. Also, prefer StandardError, or in this case even Apipie::Error over Exception
|
Nice one. One comment inline, but should be good to go otherwise |
|
@iNecas put the change into place! Thanks for reviewing. |
|
Just an update: merged master back in and the build is green ✅ |
|
Could you rebase you branch, rather than merging the master into your branch: it makes it simpler to test and we prefer rebase over merge in general. This branch has conflicts at the moment. |
488fafd to
a9c9cf5
Compare
|
@iNecas done! |
|
Thanks @alex-tan |
|
@iNecas 👍 |
|
apipie-rails 0.5.1 released, including this change |
Addresses #466