Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow layouts to be overridable. Fixes a regression introduced in #425. #447

Merged
merged 1 commit into from
Sep 4, 2016

Conversation

nilsojes
Copy link
Contributor

@nilsojes nilsojes commented Apr 4, 2016

After upgrading to version 0.3.6 our own custom layout wasn't used. This fix makes base_path and layouts_path behave the same way.

The regression was introduced in #425.

@strika
Copy link

strika commented Jun 28, 2016

Any reason for not merging this? As far as I can tell, the failure on Travis CI is the same as the failure on the master branch so this is not related to the changes in this pull request.

screen shot 2016-06-28 at 11 54 28 am

Thanks.

@aligni
Copy link

aligni commented Sep 2, 2016

Ping here, too... Master is broken for our project for the same reason.

@iNecas
Copy link
Member

iNecas commented Sep 4, 2016

It took a while, but bringing it in now. Thanks for patience

@iNecas iNecas merged commit a1013a6 into Apipie:master Sep 4, 2016
@vlasar
Copy link

vlasar commented Sep 7, 2016

Thank you @iNecas. Any plans for deploying the latest version of the gem to Rubygems?

@aligni
Copy link

aligni commented Oct 12, 2016

Thanks, @iNecas! I'd also like to gently request a Rubygem update.

@iNecas
Copy link
Member

iNecas commented Oct 13, 2016

Sry for the delay, 0.3.7 was just pushed to rubygems

@mtparet mtparet added this to the v0.3.7 milestone Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants