Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quarkus extension #184

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

carlesarnal
Copy link
Member

No description provided.

@andreaTP
Copy link
Member

@carlesarnal even just for tracking purposes, can you explain the rationale for this PR?

@carlesarnal
Copy link
Member Author

carlesarnal commented Sep 12, 2023

The rationale is that the Quarkus extension is going to be contributed to the https://github.com/quarkiverse/quarkus-openapi-generator repo and to the Quarkiverse, so it should not be here anymore.

(Sorry for not adding the details here)

@andreaTP
Copy link
Member

I think we are going a little wild here, the source code was removed > 1 month ago and is nowhere at the moment.

Probably, the best would be to revert this PR and drop the code here only when it's merged(if not released) from the other repo, thoughts?

cc. @EricWittmann

@carlesarnal
Copy link
Member Author

I think we are going a little wild here, the source code was removed > 1 month ago and is nowhere at the moment.

Probably, the best would be to revert this PR and drop the code here only when it's merged(if not released) from the other repo, thoughts?

The code "is" there (in the sense that it's in the repository, obviously not released, merged etc), but I wanted to remove the extension to not have more releases so people don't start using it from the wrong repository and dependency. If we revert this, I'm afraid people might start using it from here. In any case, open to other opinions.

cc. @EricWittmann

@carlesarnal
Copy link
Member Author

@andreaTP
Copy link
Member

FYI @andreaTP quarkiverse/quarkus-openapi-generator#482

Thanks, I appreciate the PR is still in a Draft state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants