Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow merge_reports to work with single report #32

Merged
merged 4 commits into from
Jan 16, 2023
Merged

fix: allow merge_reports to work with single report #32

merged 4 commits into from
Jan 16, 2023

Conversation

antazoey
Copy link
Member

What I did

Issue where had to have custom method for handling reports for when there was a single report.

How I did it

Delete 2 identical, unneeded checks.

How to verify it

Can call merge_reports with single report.
I added a test!

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey force-pushed the fix/merge-reports-handle-1 branch from 39c45a2 to d1ef9a7 Compare January 16, 2023 20:51
@antazoey antazoey mentioned this pull request Jan 16, 2023
Merged
3 tasks
@antazoey antazoey merged commit c27e848 into ApeWorX:main Jan 16, 2023
@antazoey antazoey deleted the fix/merge-reports-handle-1 branch January 16, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@NotPeopling2day NotPeopling2day Awaiting requested review from NotPeopling2day

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @fubuloubu