Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set root kwargs for parity trace at end of builder-logic #29

Merged
merged 2 commits into from
Nov 30, 2022
Merged

fix: set root kwargs for parity trace at end of builder-logic #29

merged 2 commits into from
Nov 30, 2022

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Nov 30, 2022 •
edited
Loading

What I did

To more honorably honor the overrides and actually have them work, they should be set after we build up the object from the call data.

Additionally, fixed many small things in the code base.

How I did it

Adds in the root_kwargs at end of function instead of beginning.

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey requested review from a user and fubuloubu November 30, 2022 15:22
@antazoey antazoey changed the title chore: clean-up done while investigating issues fix: set root kwargs for parity trace at end of builder-logic Nov 30, 2022
@antazoey antazoey mentioned this pull request Nov 30, 2022
Merged
4 tasks
ghost
ghost approved these changes Nov 30, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

evm_trace/base.py Show resolved Hide resolved
evm_trace/parity.py
@@ -153,17 +156,19 @@ def get_calltree_from_parity_trace(
)

elif root.call_type == CallType.SELFDESTRUCT:
selfdestruct_action: SelfDestructAction = root.action # type: ignore
selfdestruct_action: SelfDestructAction = cast(SelfDestructAction, root.action)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept wanting to read this as self.destruct_action 😂

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang overloaded self!

@antazoey antazoey merged commit b042c1f into ApeWorX:main Nov 30, 2022
@antazoey antazoey deleted the fix/jules/gas-fix branch November 30, 2022 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@NotPeopling2day NotPeopling2day Awaiting requested review from NotPeopling2day

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @fubuloubu