fix: issue where could not handle missing memory #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
commented
Oct 31, 2022
| @@ -9,6 +9,11 @@ def test_trace_frame_validation_passes(trace_frame_data): | |||
| assert frame | |||
|
|
|||
|
|
|||
| def test_trace_no_memory(): | |||
| raw_frame = {"pc": 0, "op": "PUSH1", "gas": 4732305, "gasCost": 3, "depth": 1, "stack": []} | |||
There was a problem hiding this comment.
I get this trace from calling this method: https://github.com/fubuloubu/ERC4626/blob/main/contracts/test/Token.vy#L68-L70
which must not use any memory?
There was a problem hiding this comment.
I should add that I was using geth and not hardhat when doing this.
There was a problem hiding this comment.
which must not use any memory?
It might not be
9cc879b to
2916174
Compare
2916174 to
ea5a295
Compare
ea5a295 to
f0f883e
Compare
3 tasks
fubuloubu
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
ValidationErrorwith missing memory.How I did it
How to verify it
Checklist