Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: display_nodes prop -> get_display_nodes() #16

Merged
merged 1 commit into from
Sep 7, 2022
Merged

refactor: display_nodes prop -> get_display_nodes() #16

merged 1 commit into from
Sep 7, 2022

Conversation

NotPeopling2day
Copy link
Contributor

What I did

Changing the display_nodes property to a method. This will help with creating a generic interface in ape core.

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@NotPeopling2day NotPeopling2day mentioned this pull request Sep 7, 2022
Closed
3 tasks
@NotPeopling2day NotPeopling2day merged commit 6acb4c0 into ApeWorX:main Sep 7, 2022
@NotPeopling2day NotPeopling2day deleted the refactor/display-nodes branch September 7, 2022 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@antazoey antazoey antazoey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NotPeopling2day @fubuloubu @antazoey