Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow provider plugins to define NAME at class-level #2428

Merged
merged 4 commits into from
Dec 20, 2024
Merged

feat: allow provider plugins to define NAME at class-level #2428

merged 4 commits into from
Dec 20, 2024

Conversation

antazoey
Copy link
Member

What I did

this allow plugins like ape-titanoboa use the name boa instead of titanoboa.

How I did it

NAME
(also see the TODOS, itll be cleaner in 0.9)

How to verify it

pip install path/to/ape-titanoboa
ape console --network ::boa

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey changed the title feat: allow defined NAME at provider class-level feat: allow provider plugins to define NAME at class-level Dec 19, 2024
@antazoey antazoey force-pushed the feat/provider-name-defined-at-cls branch from 72902f2 to b26c443 Compare December 19, 2024 21:29
@antazoey antazoey requested a review from fubuloubu December 19, 2024 21:30
@antazoey antazoey enabled auto-merge (squash) December 20, 2024 15:56
@antazoey antazoey merged commit cb43786 into ApeWorX:main Dec 20, 2024
18 checks passed
@antazoey antazoey deleted the feat/provider-name-defined-at-cls branch December 20, 2024 18:21
antazoey added a commit to antazoey/ape that referenced this pull request Dec 20, 2024
@antazoey
feat: allow provider plugins to define NAME at class-level (ApeWorX#2428
26efc7b 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotPeopling2day NotPeopling2day NotPeopling2day approved these changes

@bitwise-constructs bitwise-constructs bitwise-constructs approved these changes

@fubuloubu fubuloubu Awaiting requested review from fubuloubu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antazoey @bitwise-constructs @NotPeopling2day