Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always quote objects property names #31

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

AndyOGo
Copy link
Contributor

@AndyOGo AndyOGo commented Sep 2, 2024

fixes #30

Screenshot 2024-09-02 at 10 08 40

@AndyOGo AndyOGo force-pushed the bugfix/quote-json-proptery-names branch from 89eadb4 to efd5318 Compare September 3, 2024 17:38
@@ -17,7 +17,8 @@ export interface StyleProps {
expandIcon: string;
collapseIcon: string;
collapsedContent: string;
noQuotesForStringValues: boolean;
noQuotesForStringValues?: boolean;
quotesForFieldNames?: boolean;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AnyRoad
I updated this PR to make field name quotes optional via quotesForFieldNames style config.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@AnyRoad AnyRoad merged commit 324ae98 into AnyRoad:release Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON property names are strings and should be quoted
2 participants