Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For internal review-1 #1

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

rashmikampurath
Copy link

@AnujaChangede
@madhura-kulkarni-mh
These files are for internal language review.

en/core-api/cardless-credit.md Outdated Show resolved Hide resolved
en/core-api/cardless-credit.md Show resolved Hide resolved
@@ -16,48 +18,61 @@ Basic integration process of Cardless Credit will be explained below.
</article>
</details>

#### Sandbox Environment
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this line as is?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?>Note: The steps given below are used to test the integration process in the Sandbox environment. Please make sure that you use the Server Key and Client Key for the Sandbox environment. For more details, refer to Retrieving Access keys

I have added these as notes.What do you think?

en/core-api/cardless-credit.md Outdated Show resolved Hide resolved
en/core-api/cardless-credit.md Outdated Show resolved Hide resolved

On the Finish Redirect URL script, we need to obtain the response sent to the finish url script. Please make sure the `Finish Redirect URL` endpoint can receive POST. The sample code below are written in native php. Please adjust to your own environment.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A sample code in Native PHP is given below.


When the transaction status changes, you are directly notified about the changes in the transaction through redirect URL and also on merchant's backend. Midtrans sends HTTP notification to merchant's backend. This ensures that you are updated of the transaction status securely.

HTTP POST request with JSON body will be sent to your *Payment Notification URL* configured on dashboard.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...... with JSON body is sent to your .....


4. Click **Update**.

A confirmation message is displayed.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check preceding spaces in transition lines after step 2 and 4. They do not seem consistent.

@@ -376,3 +528,4 @@ To use Midtrans production environment (accept real payment from real customer),
</div>

<hr>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra line?

#### [Handling Webhook HTTP Notification](/en/after-payment/http-notification.md)
</div>
## Switching To Production
To use Midtrans *Production* environment (accept real payment from real customer), please make sure to follow the steps given below.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(accept real payment from real customer) <- Is this required? Check in other files too,
remove "please make sure to"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants